Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for setting custom colorbutton style definitions #4032

Merged
merged 2 commits into from
May 7, 2020
Merged

Conversation

jacekbogdanski
Copy link
Member

What is the purpose of this pull request?

Docs update

Does your PR contain necessary tests?

All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

Did you follow the CKEditor 4 code style guide?

Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.

  • PR is consistent with the code style guide

What is the proposed changelog entry for this pull request?

Not required.

What changes did you make?

Docs update.

Which issues does your PR resolve?

Closes #3994

@f1ames f1ames self-requested a review May 7, 2020 11:42
@f1ames f1ames self-assigned this May 7, 2020
Copy link
Contributor

@f1ames f1ames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially I was thinking about some broader explanation with a sample, but since we have extensive ACF docs, such short note should be sufficient to point in the right direction :+1:

@f1ames f1ames merged commit caa0461 into master May 7, 2020
@f1ames f1ames deleted the t/3994 branch May 7, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants